search

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
164 stars 90 forks source link

Update available costing options #32

Closed nilsnolde closed 1 year ago

nilsnolde commented 1 year ago

We should update this app soon. We got a few more costing options merged recently.

nilsnolde commented 1 year ago

@chrstnbwnkl , the latest when we add your lit PR to Valhalla, we'll take care of this. That one I'd definitely like to include in the web app:)

ayush4345 commented 1 year ago

Hello, can you tell me where I have to add costing options in the web app ?

As I am not able to find costing options on the website as of now.

nilsnolde commented 1 year ago

It’s what you see in the right panel, the input to Valhalla. That’s all the context you’ll need, the rest is research.

hs7898753 commented 1 year ago

Please Assign me this issue.

nilsnolde commented 1 year ago

Should we start by listing the missing costing options?

hs7898753 commented 1 year ago

Yah! Sure

hs7898753 commented 1 year ago

How to decide where to keep which costing option in Extra Settings or General Settings? Ex: for bss_return_cost for Bicycle

nilsnolde commented 1 year ago

if smth is generally being used by many costing models, we keep it in general settings, if it's model-specific, e.g. bss_return_cost then it goes into the extra settings.

hs7898753 commented 1 year ago

In the API reference PEDESTRIAN COSTING OPTIONS include (bss_rent_cost and bss_rent_penalty) which are bicycle costing options. should I add these options to Pedestrial or not?

nilsnolde commented 1 year ago

How do you know it’s for bike? Could be, I’d need to check the Valhalla code. bss stands for bike share station. It’s a multimodal concept of ped & bike, but doesn’t have its own costing. So options for bss can show up on both costings.

In fact, you can disregard the bss stuff for the PR. We don’t support that yet anyways in the web app.