search

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
163 stars 90 forks source link

Rewrite using functional components #68

Open chrstnbwnkl opened 1 year ago

chrstnbwnkl commented 1 year ago

While React class components are not going anywhere any time soon, functional components have become the new norm. A rewrite using functional components and hooks could make the application future proof and might offer a way to simplify the code along the way (especially the React <-> Leaflet interactions, which are all buried inside one big Map component).

inceptionabhishek commented 1 year ago

Please Assign me this issue, I can work on this.

aa98-45556443355666 commented 1 year ago

I want to work on this issue . Kindly assign it to me.

nilsnolde commented 1 year ago

This is too big for applicants, it'll be part of the main GSoC project.

theWiseAman commented 1 year ago

@nilsnolde Can I work on some files though? I have experience as a ReactJS Developer so I know what is being asked here. So can you assign me this issue?

nilsnolde commented 1 year ago

Then you'd handle it pretty efficiently once the project started I think. There are lots of open, unassigned issues, please choose one of those. It's more important for the pre-selection to see how you do things you're not familiar with.

sammaji commented 1 year ago

While React class components are not going anywhere any time soon, functional components have become the new norm. A rewrite using functional components and hooks could make the application future proof and might offer a way to simplify the code along the way (especially the React <-> Leaflet interactions, which are all buried inside one big Map component).

@chrstnbwnkl This is a pretty big issue. It is better to handle it in parts. Would be nice, if you could provide a list of files that need work first.

nilsnolde commented 1 year ago

Again, reading capability is a requirement.

sammaji commented 1 year ago

Again, reading capability is a requirement.

Can you point out some issue that needs solving?

tommach591 commented 1 year ago

I submitted a proposal for GSoC 2023 to work on this issue and I was wondering if there are any feedbacks on it.

Ananya2001-an commented 1 year ago

Hey @nilsnolde do u think I should start working on this on the side....it will take time but better to start now so that later on other issues can also be resolved and anyways I am free ;)