search

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
163 stars 90 forks source link

Route summary reporting error fixed #69

Closed rakeshhotker closed 1 year ago

rakeshhotker commented 1 year ago

As told, i reverted to the Route summary reporting error so as to focus on one bug.

rakeshhotker commented 1 year ago

Could you please be more descriptive

nilsnolde commented 1 year ago

You copy/pasted this function as-is from another place in the same codebase. You're repeating the same stuff, that's never good.

Did you look at #94? You'll need to merge master, then you can apply your changes while having the function live somewhere else and called by both modules.

aaryahjolia commented 1 year ago

Can I make a PR on this @nilsnolde ? I solved this issue by DRY principle and in hh:mm:ss format.

nilsnolde commented 1 year ago

Depends if @rakeshhotker is dropping the contribution or not, I'd still give him some time.