search

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
163 stars 90 forks source link

added remember map extent (#50) #73

Closed sandstone991 closed 1 year ago

sandstone991 commented 1 year ago

Hello, sorry if this is against rules because I didn't ask to be assigned first. Anyway added a simple debounce to store the last lat & lng the user viewed as well as the zoom level, and in the componentDidMount life cycles I check for these items in the localStorage if they're there I take them and replace the default mapParams.

nilsnolde commented 1 year ago

I think this is fine technically, but our bigger point, apart from communicating that you want to work an issue for GSoC, was that you shouldn’t do more than 1.

You’re interested in GSoC I assume right?

sandstone991 commented 1 year ago

@nilsnolde

I think this is fine technically, but our bigger point, apart from communicating that you want to work an issue for GSoC, was that you shouldn’t do more than 1.

Yeah I misunderstood that, sorry for the inconvenience though.

You’re interested in GSoC I assume right?

Yes.

nilsnolde commented 1 year ago

closing for now and will merge your other pr