search

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
163 stars 90 forks source link

feat: format downloaded JSON file #75

Closed Ananya2001-an closed 1 year ago

Ananya2001-an commented 1 year ago

Problem Currently the json files are not well formatted which reduces readability and understandability.

Solution We can use an npm package 'json-format' to format the files with proper spaces.

Screenshots right now sddsd

after formatting

Screenshot 2023-03-02 135343

Ananya2001-an commented 1 year ago

I have already solved the issue. If it's approved I will raise a PR. Kindly assign it to me.

nilsnolde commented 1 year ago

Thanks for the suggestion. I was about to decline (more dependencies, the triviality of making it human-readable etc), but maybe you're right, it's more convenient and in the spirit of what the export is supposed to do for a user.

Happy to have the PR, thanks. This is GSoC related I assume?

Ananya2001-an commented 1 year ago

Thanks for the suggestion. I was about to decline (more dependencies, the triviality of making it human-readable etc), but maybe you're right, it's more convenient and in the spirit of what the export is supposed to do for a user.

Happy to have the PR, thanks. This is GSoC related I assume?

Thanks for approving @nilsnolde. I will raise a PR soon. Yes I am willing to make a proposal for GSOC when the application period begins.