search

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
163 stars 90 forks source link

feat: formatted JSON response #76

Closed Ananya2001-an closed 1 year ago

Ananya2001-an commented 1 year ago

Fixes issue closes #75

Screenshots JSON export Screenshot 2023-03-02 160652

GeoJSON export Screenshot 2023-03-02 160721dfdff

Ananya2001-an commented 1 year ago

@nilsnolde Kindly review the changes.

Ananya2001-an commented 1 year ago

perfect thanks!

Awesome!

Ananya2001-an commented 1 year ago

Hey @nilsnolde there are also many other issues for which I might raise a PR. But first I will raise an issue to get your agreement on it. Hope that's ok?

nilsnolde commented 1 year ago

I appreciate your enthusiasm, but as outlined in the wiki we only want one issue per applicant fixed. The rest will be for the actual project.

Ananya2001-an commented 1 year ago

I appreciate your enthusiasm, but as outlined in the wiki we only want one issue per applicant fixed. The rest will be for the actual project.

Sure I don't want to take up all the issues. I will definitely work on only one at a time. 👍

Ananya2001-an commented 1 year ago

I appreciate your enthusiasm, but as outlined in the wiki we only want one issue per applicant fixed. The rest will be for the actual project.

Sure I don't want to take up all the issues. I will definitely work on only one at a time. 👍

Does that mean I can't contribute anymore till the time project starts for gsoc?

nilsnolde commented 1 year ago

Let's say until you're the one chosen for the project.

Of course you're free to contribute, but we won't consider anything else than this PR in our decision. It's to protect ourselves. If you're willing to stay on the project as a contributor, we'd be happy obviously:) But for now, we need to be careful with our resources until the application period ended.

Ananya2001-an commented 1 year ago

Let's say until you're the one chosen for the project.

Of course you're free to contribute, but we won't consider anything else than this PR in our decision. It's to protect ourselves. If you're willing to stay on the project as a contributor, we'd be happy obviously:) But for now, we need to be careful with our resources until the application period ended.

Okay so that means for my gsoc proposal only this PR will be considered but till the time application period begins I can still contribute, right?

nilsnolde commented 1 year ago

so that means for my gsoc proposal only this PR will be considered

Right.

till the time application period begins I can still contribute, right?

Sure, if you're willing to:) I'd just ask to not take existing issues if that's ok with you, until end of March. New ones are always welcome. Do understand if it might take a few days for review.

Ananya2001-an commented 1 year ago

so that means for my gsoc proposal only this PR will be considered

Right.

till the time application period begins I can still contribute, right?

Sure, if you're willing to:) I'd just ask to not take existing issues if that's ok with you, until end of March. New ones are always welcome. Do understand if it might take a few days for review.

Awesome. Got it. Thanks for the detailed explanation @nilsnolde Hoping to contribute more in the future 😊