search

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
163 stars 90 forks source link

SliderValue issue #77

Closed Ghat0tkach closed 1 year ago

Ghat0tkach commented 1 year ago

Whenever we do some change in Extra Settings using Slider , the value gets output in the javascript console which in turn makes the app a bit slow. Before raising this issue, I went thoroughly through the codebase to check whether this is done intentionally or not.

Screenshot (52)

Suggested fix

it's a simple fix, we have to remove or comment on the console.log(SliderVal) from the code, this will resolve the issue.

nilsnolde commented 1 year ago

Yeah that was annoying me since ages too.. But apparently never enough to go and look for the issue :sweat_smile:

Ghat0tkach commented 1 year ago

Is it okay if i add this into my already raised PR? Moreover its a simple issue could be solved by anyone , more preferably by the people who are complete beginner and would love to contribute in this project :)

nilsnolde commented 1 year ago

Is it okay if i add this into my already raised PR

Yeah totally, thanks!