search

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
163 stars 90 forks source link

Text besides time icon, breaks the defined size #91

Closed aditygrg2 closed 1 year ago

aditygrg2 commented 1 year ago

Check the images -

Screenshot 2023-03-06 at 13 56 21 Screenshot 2023-03-06 at 13 56 13

The text besides the time icon, is not in a single line, which distorts UI and doesn't look good.

This can be improved by either shortening the text, for example, min can be written as m, and seconds as s or we can reduce the text size, or give it more space, but the latter one will require more refactoring, and the first one is easy to fix and UI will not be affected much.

If needed, I can solve this issue as my pre-gsoc work.

nilsnolde commented 1 year ago

Yeah I agree. In fact let's do the hh:mm:ss format.

aditygrg2 commented 1 year ago

@nilsnolde There are days defined as well. I think it will be confusing if we keep hh:mm::ss format, a d,h,m,s format will look more better.

nilsnolde commented 1 year ago

Yeah I think that was the reason why we did it this way as it could potentially wrap around 24 hours into the next day (though the public server limits for Valhalla are strict enough that it likely won't happen, other than for pedestrian profile maybe). I'm fine with your proposal too, still better than currently.

aditygrg2 commented 1 year ago

Great, thank you, will add a PR!