search

gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
163 stars 90 forks source link

Improved control tabs in Left side panel #98

Closed aaryahjolia closed 1 year ago

aaryahjolia commented 1 year ago

🛠️ Fixes Issue

Closes #88

👨‍💻 Changes proposed

  1. The directions and isochrones button were not fully occupying the width, So I extended them to use full width. (See images)
  2. The slider in setting in Isochrones section was having a padding-left but not padding-right due to which it was not looking good. I added padding-right also so it aligns in the center with equidistance from both sides.

📄 Note to reviewers

While I was roaming in the code base, I found that most of the part of CSS is not written properly, changing one part affects another part adversely. Can I start writing my proposal around refactoring most of the codebase (mostly CSS and adding some new functionalities also) so that it would be written in accordance of standard practices.

📷 Screenshots

  1. Before: image After:
    image

  2. Before: image After:
    image

nilsnolde commented 1 year ago

LGTM, thanks!

I found that most of the part of CSS is not written properly, changing one part affects another part adversely.

I can believe that! We'd like a re-write of the app, CSS/styling handling could very well be part of it. We'd like to do #68 as well.

aaryahjolia commented 1 year ago

Excellent @nilsnolde , Can I start writing my proposal of rewriting the code from Class to function based React, Improving CSS, etc. or do I need some more PR before my proposal?