gis-ops / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
163 stars 90 forks source link

[BUG] Directions Waypoint overflow #99

Closed tommach591 closed 1 year ago

tommach591 commented 1 year ago

Description

List of waypoints extend outside the box.

I think we should make the list of waypoints scrollable instead. I would like to work on it for GSoC.

Screenshots

overflow

Ghat0tkach commented 1 year ago

Oh didn't noticed it , but if we changed the behaviour to scroll then the geocoding results shall also be scrollable .

nilsnolde commented 1 year ago

Yep, good point, I agree!

then the geocoding results shall also be scrollable .

Also good point:) You solved it via z-index right? Maybe it'll override the scroll area?

Ghat0tkach commented 1 year ago

The z index was already intact , i used the overflow:inherit property to make the child element (search results ) extend vetically. However it also impacted the main parent element.

tommach591 commented 1 year ago

I made the waypoints scrollable, but I haven't found a solution for the geocoding results yet.

Closest I got was by using position: absolute, but that ruins everything else. I also haven't found a solution using z-index yet.

Ghat0tkach commented 1 year ago

I do have an idea, whenever we click on the add waypoint the parent div class name shall change to "flex flex-column overflow:auto" from "flex flex-column' . And whenever we click on search it shall revert back to original

ankitjangidx commented 1 year ago

I made the waypoints scrollable, but I haven't found a solution for the geocoding results yet.

Closest I got was by using position: absolute, but that ruins everything else. I also haven't found a solution using z-index yet.

why this bug is not visible to me :( Screenshot 2023-03-07 143306

tommach591 commented 1 year ago

I made the waypoints scrollable, but I haven't found a solution for the geocoding results yet. Closest I got was by using position: absolute, but that ruins everything else. I also haven't found a solution using z-index yet.

why this bug is not visible to me :( Screenshot 2023-03-07 143306

When you search for a location, the search results also become scrollable.

Capture

We want the search results to not be part of the scrolling.

Capture2

ankitjangidx commented 1 year ago

new bug:/ @tommach591 image image