search

gis-ops / valhalla-qgis-plugin

QGIS plugin to use Valhalla for routing, isochrones and matrices.
GNU General Public License v3.0
12 stars 3 forks source link

Only integer km values possible for isochrones? #5

Closed magerlin closed 1 year ago

magerlin commented 3 years ago

Using the Processing module for isochrones it is impossible for me to specify isochrones distances in decimal kilometers like 0.5 and 1.5:

Traceback (most recent call last): File "C:\Users/MAP/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\valhalla\proc\isochrones\isochrones_layer_auto.py", line 365, in processAlgorithm "distance": [{"distance": int(x)} for x in intervals_distance.split(',')] if intervals_distance else [] File "C:\Users/MAP/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\valhalla\proc\isochrones\isochrones_layer_auto.py", line 365, in "distance": [{"distance": int(x)} for x in intervals_distance.split(',')] if intervals_distance else [] ValueError: invalid literal for int() with base 10: '0.5'

Execution failed after 0.01 seconds

Decimal kilometres are relevant when working with pedestrians....

nilsnolde commented 3 years ago

We’re actually about to deprecate this (was a bit polished debugging tool for our Valhalla dev), as a much better plugin is coming soonish.

we might fix this and re-publish. Or you just fix it in your local plugin code?

magerlin commented 3 years ago

Hi Nils

Even though my Python knowledge is limited I actually have considered trying to fix it myself. Guess it should be quite simple. Will look at it.

And as a transportplanner I will look forward for the new polished version 😊

Have a nice weekend!

Best regards/Med venlig hilsen

Morten Agerlin Petersen

From: Nils @.> Sent: Friday, October 1, 2021 9:22:39 AM To: gis-ops/valhalla-qgis-plugin @.> Cc: Morten Agerlin Petersen @.>; Author @.> Subject: Re: [gis-ops/valhalla-qgis-plugin] Only integer km values possible for isochrones? (#5)

We’re actually about to deprecate this (was a bit polished debugging tool for our Valhalla dev), as a much better plugin is coming soonish.

we might fix this and re-publish. Or you just fix it in your local plugin code?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgis-ops%2Fvalhalla-qgis-plugin%2Fissues%2F5%23issuecomment-931975707&data=04%7C01%7Cmap%40ramboll.dk%7C4066ec4aaa734ceeb4ed08d984ac40f4%7Cc8823c91be814f89b0246c3dd789c106%7C0%7C0%7C637686697630605995%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=1xCGuhFNJjYYxpv%2F8m94ViGbSSfYaritZZHqzMZSLXU%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAOM2KY7G36L5AXE3WCNQVLUEVOT7ANCNFSM5FD7W7HA&data=04%7C01%7Cmap%40ramboll.dk%7C4066ec4aaa734ceeb4ed08d984ac40f4%7Cc8823c91be814f89b0246c3dd789c106%7C0%7C0%7C637686697630615991%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=FDBLjY%2BVaJUZ3BwCs3MY8x0KzTlJH6HdhJtBIkwfY9w%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cmap%40ramboll.dk%7C4066ec4aaa734ceeb4ed08d984ac40f4%7Cc8823c91be814f89b0246c3dd789c106%7C0%7C0%7C637686697630615991%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=lLO%2FNFOi0VVmBplSBTCYs7CqQR9LO4wtbWAfw%2BRbXZw%3D&reserved=0 or Androidhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cmap%40ramboll.dk%7C4066ec4aaa734ceeb4ed08d984ac40f4%7Cc8823c91be814f89b0246c3dd789c106%7C0%7C0%7C637686697630625979%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=upcpMt5nATpDNkETVkJLjW6xiAPgFqTm8PYoQaSpcz8%3D&reserved=0.

nilsnolde commented 3 years ago

Ha great, you can definitely be one of our beta testers if you want! Our end goal will be similar as ESRI's network analyst and will contain location/allocation/optimization/isochrones and a street view (all roads as geometries reachable within a certain time, very similar to isochrones) and you won't have to have a API anymore, it'll all run locally with valhalla & osrm. we're actually really excited to release that, but might take until the end of the year before we have a beta to distribute around.

as for the python: just replace the int with float and it'll work:)

magerlin commented 2 years ago

Hi Nils

I have managed to make Valhalla calculate isochrones using floating intervals by changing INT to FLOAT in isochrones_layer_auto.py:

@.***

I also changed it in isochrones_core.py but I do not think that actually was necessary or did any change:

@.***

The resulting polygons are now correctly calculated and drawn using the floating values even though they still are labelled and categorized using int values but I can live with that for now.

If you are reusing some of the code I will point at one general error in the Isochrone results: Resulting polygons for both time and distance are labelled “mins”:

When I ask for: @.***

I get these polygons: @.***

As a descendant of the Danish Vikings I will enjoy to help making Valhalla great 😊 and participate in beta testing!

Kind regards Morten Agerlin Petersen Senior Transport Planner, GIS and Data Analysis Specialist M +45 51613615 @.**@.> Rambøll Danmark A/S, CVR NR. 35128417 Hjemsted: Hannemanns Allé 53, 2300 København S

From: Nils @.> Sent: fredag den 1. oktober 2021 14:04 To: gis-ops/valhalla-qgis-plugin @.> Cc: Morten Agerlin Petersen @.>; Author @.> Subject: Re: [gis-ops/valhalla-qgis-plugin] Only integer km values possible for isochrones? (#5)

Ha great, you can definitely be one of our beta testers if you want! Our end goal will be similar as ESRI's network analyst and will contain location/allocation/optimization/isochrones and a street view (all roads as geometries reachable within a certain time, very similar to isochrones) and you won't have to have a API anymore, it'll all run locally with valhalla & osrm. we're actually really excited to release that, but might take until the end of the year before we have a beta to distribute around.

as for the python: just replace the int with float and it'll work:)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgis-ops%2Fvalhalla-qgis-plugin%2Fissues%2F5%23issuecomment-932169277&data=04%7C01%7Cmap%40ramboll.dk%7Cd18c72582e4142d9805908d984d39f81%7Cc8823c91be814f89b0246c3dd789c106%7C0%7C0%7C637686866727209987%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=wrrpc9VOG2SETJJGxDZXjfww%2FPs%2BsGz%2BWTtdb%2BFR4fk%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAOM2K4RV22WVQKMDRUQXC3UEWPUZANCNFSM5FD7W7HA&data=04%7C01%7Cmap%40ramboll.dk%7Cd18c72582e4142d9805908d984d39f81%7Cc8823c91be814f89b0246c3dd789c106%7C0%7C0%7C637686866727219980%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=LOsIjP3ddCo4seL3tV0aPbJM%2BUy%2BSZH4j6VuMRnrrbU%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cmap%40ramboll.dk%7Cd18c72582e4142d9805908d984d39f81%7Cc8823c91be814f89b0246c3dd789c106%7C0%7C0%7C637686866727219980%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=pLP2N6%2BVSkEjZlx88m9RBFGwBOHCuFemtvrr3iXdLW0%3D&reserved=0 or Androidhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cmap%40ramboll.dk%7Cd18c72582e4142d9805908d984d39f81%7Cc8823c91be814f89b0246c3dd789c106%7C0%7C0%7C637686866727229974%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=56jYyzCjDuLqDF6VExJ7NQqffQJ5F%2FTcqd2rMGcAr0A%3D&reserved=0.