search

gisaia / ARLAS-proc

Workaround about data ingestion with computing frameworks
Apache License 2.0
4 stars 0 forks source link

Make RunOptions overridable #99

Closed laurent-thiebaud-gisaia closed 5 years ago

laurent-thiebaud-gisaia commented 5 years ago

Create an abstract RunOptions with abstract factory. These can be extended from other projects that will need their own run options

laurent-thiebaud-gisaia commented 5 years ago

Please note that warmingPeriod and endingPeriod aren't used anymore. I removed them from RunOptions to make things simplier. However I let their computation into the RunOptionsAbstractFactory in case we need them. I guess this should be cleaned with the specific applications (Transformer, EsLoader...) that aren't used anymore.

laurent-thiebaud-gisaia commented 5 years ago

Please note that warmingPeriod and endingPeriod aren't used anymore. I removed them from RunOptions to make things simplier. However I let their computation into the RunOptionsAbstractFactory in case we need them. I guess this should be cleaned with the specific applications (Transformer, EsLoader...) that aren't used anymore.