giscus / giscus

A comment system powered by GitHub Discussions. :octocat: :speech_balloon: :gem:
https://giscus.app
MIT License
7.8k stars 317 forks source link

iFrameSizer is detected in my console - Vue #394

Closed giwonn closed 2 years ago

giwonn commented 2 years ago

image

Hello, It hasn't been a few days since I used this app.
But this app is really amazing!

But unfortunately, These warning and error is occured in my website.

First, the reason for the error is that there are no comments on this page.

And for the warnings... I don't know why that is occured.

How can I solve these problems?

laymonage commented 2 years ago

Hi, please update to @giscus/vue v1.1.1 and see if the issue is gone. The "Discussion not found" message is expected, unless you have created a discussion but for some reason giscus can't find it.

giwonn commented 2 years ago

Hi, please update to @giscus/vue v1.1.1 and see if the issue is gone. The "Discussion not found" message is expected, unless you have created a discussion but for some reason giscus can't find it.

Thank you for reply quickly!

I checked these issues again,

I found only one warning. This warning still remains. [iFrameSizer][Host page: iFrameResizer0] [Tab Visable] IFrame(iFrameResizer0) not found

And how can I remove the history of discussion in the giscus? I think the reason for the problem is that I removed some discussions myself.

laymonage commented 2 years ago

I checked these issues again,

I found only one warning. This warning still remains. [iFrameSizer][Host page: iFrameResizer0] [Tab Visable] IFrame(iFrameResizer0) not found

It seems your yarn.lock is still using v1.1.0: https://github.com/giwonn/giwonn.github.io/blob/a80a5f7bc64e95cb7c009209c4e049560d22ab2e/yarn.lock#L156-L157

Try running yarn install and commit the updated yarn.lock file.

And how can I remove the history of discussion in the giscus? I think the reason for the problem is that I removed some discussions myself.

I'm sorry, I don't understand the question. Could you clarify? If you need to remove the discussion/comments, you can do so from GitHub. If you want to hide discussion on certain pages, make sure to not use the <Giscus> component in those pages.

giwonn commented 2 years ago

Thank you! Everything is work!