search

giselles-ai / giselle

Giselle: AI for Agentic Workflows. Human-AI Collaboration. Open Source.
https://giselles.ai
Apache License 2.0
10 stars 4 forks source link

Fix license_finder job failure for PRs from a forked repository #57

Closed masutaka closed 1 week ago

masutaka commented 1 week ago

Summary

For PRs from forked repositories, the license_finder job was failing because it could not reference repository variables and secrets.

Since the license_finder job is a required check for PR merging, there was a problem that PRs could not be merged even if they were approved.

This PR fixes the above.

Related Issue

Nothing

Changes

The license_finder job triggered by a PR from the fork repository will no longer update $LICENSE_REPORT.

Testing

PR from forked repository, license_finder job passes.✅

Other Information

Nothing

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giselle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 10:25am
masutaka commented 1 week ago

Thank you for your review.

https://github.com/route06inc/giselle/pull/57/files

# When triggered by a push to the default branch, $LICENSE_REPORT is not updated either.

It works well. 😄 https://github.com/route06inc/giselle/actions/runs/11587360483/job/32259433029