search

gisellevonbingen-Minecraft / Ad-Astra-Giselle-Addon

'Ad-Astra' random adds addon
https://www.curseforge.com/minecraft/mc-mods/ad-astra-giselle-addon
MIT License
5 stars 4 forks source link

[Feature]: Oxygen Compatibility and Generation #49

Open TheROFL98 opened 1 year ago

TheROFL98 commented 1 year ago

Cause for request

Would be nice to use the same oxygen from let's say Mekanism with Ad Astra instead of having to use separate equipment just to get oxygen.

Request details

It feels a bit annoying not being able to use Mekanism to fill up Ad Astra tanks and vice versa.

You could make it possible for the Space Breathing Unit to fill up oxygen tanks (including Ad Astra tanks) whenever there's oxygen present in the air and not just when you're underwater. Tanks between mods could also be interchangeable and can be filled with oxygen using either equipment.

Sort of unrelated but would it also be possible to counteract an ability where you can only breathe underwater and not in the air? (e.g. Origins mod - Merling)

gisellevonbingen commented 1 year ago

Ad Astra items can accept any fluid have 'forge:oxygen' tag. Ad Astra's 'Oxygen' fluid and Mekanism 'Liquid Oxygen' fluid have that tag both.

So, you have two ways.

  1. Convert Ad astra 'oxygen' fluid to Mekanism 'oxygen' gas via 'Rotary Condensentrator'.
  2. Convert Mekanism'oxygen' gas convert to fluid via 'Rotary Condensentrator' and use it.
TheROFL98 commented 1 year ago

Oh I didn't realize Ad Astra used liquid oxygen..

On the other hand it still would be nice if the Mekasuit could refill oxygen tanks when not in an oxygen-void atmosphere so you don't have to manually refill the tanks

gisellevonbingen commented 1 year ago

Space Breathing Unit in this Addon added Mekasuit upgrade will refilling held item with oxygen gas when player is in water

TheROFL98 commented 1 year ago

Space Breathing Unit in this Addon added Mekasuit upgrade will refilling held item with oxygen gas when player is in water

Only works with the Mekanism gas tank and not the oxygen can

gisellevonbingen commented 12 months ago

Only works with the Mekanism gas tank and not the oxygen can

Yeah, i just realized to it is unfair after commented.

I will change to fill oxygen can both in hand and curios slots.

gisellevonbingen commented 12 months ago

Added. Filling target is main hand and curios slots https://legacy.curseforge.com/minecraft/mc-mods/ad-astra-giselle-addon/files/4819646 https://legacy.curseforge.com/minecraft/mc-mods/ad-astra-giselle-addon/files/4819640

TheROFL98 commented 12 months ago

Brilliant! I'll have to give it a try later today.

Would there possibly be any chance of making the breathing module work with the Origins mod as well? The Mekanism Scuba gear seems to work with it just fine, but there isn't an equivalent for the Mekasuit.

gisellevonbingen commented 12 months ago

Can't say surely 'yes', but i will review about that.