gisellevonbingen-Minecraft / MineColonies_Compatibility

https://www.curseforge.com/minecraft/mc-mods/minecolonies-compatibility
GNU General Public License v3.0
3 stars 2 forks source link

Please use officially supported channels for modifying the mod wherever possible, no mixins #35

Open Thodor12 opened 1 month ago

Thodor12 commented 1 month ago

There are a load of things that this mod adds through the means of mixins which is not necessary at all. Many things can be done with datapacks directly, or through opened API's on our mod:

I have no problem with the majority of things you're trying to do, just implement them in a smarter way, mixins break too easily

gisellevonbingen commented 1 month ago
  1. Water bucket filling does not need to exist, we actually have a PR open for that right now which is just a recipe

    No, this is necessary for pickup fluid like lava into bucket.
  2. Do not mixin into the AI code, create custom AI code classes

    No, it can't implement it the way I intended.
    Many methods are declared as 'private'.
  3. Remove knights and rangers using axes and crossbows

    No, please make it from MineColonies first, then I will remove it.
  4. Farm crops are already supported.

    No, i know the farmer can't support Farmer's Delight's tomato and Immersive Engineering's Hemp and more.
  5. Remove the mixin into JobEntry.

    No, I don't want 'com.' prefix at translation key.
  6. Remove the custom tool type system.

    No, MineColonies Tool API is too inconvenient and some methodes are accept only 'ToolType', not 'IToolType'.
    And custom tool type systems is more flexiable for CustemRecipes and creating a Modpack.
  7. Do not modify building module code through mixins.

    No, it can't.