gisellevonbingen-Minecraft / MineColonies_Compatibility

https://www.curseforge.com/minecraft/mc-mods/minecolonies-compatibility
GNU General Public License v3.0
6 stars 5 forks source link

Request System not Functioning when connected to RS via “Grid for Colonist” #47

Closed AnimeFreak1029 closed 1 month ago

AnimeFreak1029 commented 2 months ago

Minecraft V1.20.1

relevant mods:

Minecolonies-1.20.1-1.1.647-beta MineColonies_compatibility-1.20.1-2.39 Minecolonies_tweaks-1.20.1-2.34 Refined Storage-1.12.4

Issue: Colonists will not Request items from warehouse when it is linked to the “Grid for Colonist, but when couriers are requested to do a pickup, they will deposit into RS System.

steps to reproduce:

start colony > have minimum of 1 level each Builder, Courier, Town Hall and warehouse. >Hire Courier at both Couriers hut and warehouse, hire Builder at Builders hut.> place down external storage attached to back of ware house, connect to Wireless Receiver attach Grid For Colonist. > open warehouse > grid is connected under “Network storage” > start any upgrade or building request. > Builder places request for Player to resolve, will not request from warehouse. Not even items STORED in the warehouse racks.

However if you disconnect the grid for colonist and put items in warehouse only like normal, it works just fine.

gisellevonbingen commented 2 months ago

Hmm. Even if deposit into RS System, request system should works. Would have any screenshot? I will check as is steps to reproduce.

'deposit into RS System' is indented, Priority is below. Insert: RS System first, warehouse after. Extract: Warehouse first, RS System after.

gisellevonbingen commented 2 months ago

Ah, you need update 'Compatibility' mod to 1.20.1-2.40. It maybe fixed at that version. https://legacy.curseforge.com/minecraft/mc-mods/minecolonies-compatibility/files/5682245 Please try agian.

AnimeFreak1029 commented 2 months ago

It seemed fixed at first. However after running for a few moments, the request system caused a stack overflow and began crashing. Each time the game crashed I would have to reset the connection to RS for it to work for a moment then crash again.

gisellevonbingen commented 2 months ago

Each time the game crashed

Please crash report.

AnimeFreak1029 commented 2 months ago

crash-2024-09-02_13.59.19-server.txt crash-2024-09-02_14.49.02-server.txt crash-2024-09-02_16.11.36-server.txt crash-2024-09-02_16.39.51-server.txt crash-2024-09-02_16.43.24-server.txt crash-2024-09-02_17.10.39-server.txt crash-2024-09-02_17.27.37-server.txt

this should be all of them

gisellevonbingen commented 2 months ago

Hmm, seem minecolonies's data corrupted. Can you rehire Leia Z. Cuddon Or enter /mc colony requestsystem-reset-all before crash?

AnimeFreak1029 commented 2 months ago

Rehire Demon_King_Miner? Thats myself. And running /mc colony request-system-reset(-all) neither one works. its a single player world, So its just me. Running the reset command periodically seems to keep it from crashing (closing) but doesnt fix the issue. Right now it seems as if the builder will put in the request, but the warehouse courier is acting like they cant access the system, even if they are able to put things in. Just refusing to pull things out.

gisellevonbingen commented 2 months ago

Sorry i missed, i mean Leia Z. Cuddon. Still crash even if you execute /mc colony request-system-reset(-all)?.

Umm.. Did you place multiple External Storage in Warehouse? Or multiple Grid for Colonist.

Would be good have a screenshot of warehouse.

AnimeFreak1029 commented 2 months ago

There is only one of each in the warehouse, in fact the only changes from the warehouse at all, is 1 wireless receiver 1 cable 1 External storage 1 Grid for colonist.

as for rehiring the colonists, both of them died in a raid so there are new colonists in their place. Warehouse

gisellevonbingen commented 2 months ago

Sorry i am failed reproduce it.

In my test. image image image

AnimeFreak1029 commented 2 months ago

Screenshot 2024-09-02 213327 Screenshot 2024-09-02 213401 Screenshot 2024-09-02 213410 Screenshot 2024-09-02 213421 Screenshot 2024-09-02 213448

My Builder is set to build a Fancy Path in the Urban Birch Pack, she is Requesting Glowstone, and i have it in my system, but the Warehouse manager refuses to move, ive checked happiness, saturation, all the stats that affect whether or not he will work. He SHOULD be working, but even the small complaints they have, cant be fixed if they wont work. I tried a post box and it wont work either.

gisellevonbingen commented 2 months ago

I am keeping testing...

Can you extract glowstone from grid gui?

AnimeFreak1029 commented 2 months ago

it is however it seems that the issue is with the warehouse blocks themselves? i had 2 warehouses, one that was just empty, unused, no workers. and the one that had my courier and the system connection. for some reason, the courier was trying to put stuff into and take from the unused warehouse instead of the assigned one. as soon as i deconstructed and picked up the unused warehouse, it started working fine. idk if thats a Minecolonies thing, or a compatibility addon thing.

gisellevonbingen commented 2 months ago

What... no workers warehouse does connected to RS System too?

I thinks it can fix from compatibility addon.

AnimeFreak1029 commented 2 months ago

so to make it easy to understand. Warehouse A and Warehouse B.

Warehouse A, was built first, was originally connected to the RS System, and was working till Warehouse B was finished (finished as in level 5). This was done so a Warehouse could be Maxed out before connecting, to prevent the connection being deleted from "repairs and Upgrades" Warehouse A was disconnected from the system, and the courier was "fired" Warehouse B was then connected to the system and the courier that WAS at Warehouse A was hired at Warehouse B. Warehouse A was basically abandoned and at first everything was working fine till the first Crash when it suddenly stopped. Now, After Tearing down Warehouse A. the courier is working as Intended. I suspect that since part of the issue was the Courier, While Assigned to Warehouse B, was still trying to go to Warehouse A, if BOTH Warehouses were connected to the system, it would work regardless, because they would "Share the Same Inventory"

gisellevonbingen commented 2 months ago

Nice. I can reproduce issue, through fire courier and create a new Warehouse. Thanks for your effort. :heart:

gisellevonbingen commented 2 months ago

This problem is came from MineColonies in my think. In my test, Courier was do nothing even if no Grid for Colonist in same situation.