search

gisellevonbingen-Minecraft / MineColonies_Compatibility

https://www.curseforge.com/minecraft/mc-mods/minecolonies-compatibility
GNU General Public License v3.0
6 stars 5 forks source link

Ewewukek's Musket Mod damage incorrect #52

Open xianyullm opened 2 months ago

xianyullm commented 2 months ago

Musket with Bayonet deals 16 damage when firing, but Gunner deals 8 damage when firing Musket with Bayonet. In addition, the Sharpness curse does not affect Gunner's damage when using the Musket with Bayonet melee.Gunner's agility and adaptability do not increase damage as described. Ewewukek's Musket Mod version: 1.5.2 MineColonies version: 1.20.1-1.1.673 Compatibility add-on for MineColonies version: 1.20.1-2.42 I really like your mod and look forward to your prompt repair

gisellevonbingen commented 2 months ago

Damage will be half if shooter is not player by Musket Mod (https://github.com/ewewukek/mc-musketmod/blob/a3767f275f0c0101df34586bf86b59d75ff6e3d9/src/main/java/ewewukek/musketmod/BulletEntity.java#L322)

Melee damage is intended, i think is should be fixed value.

Enchantment is will be fix.

gisellevonbingen commented 2 months ago

MineColonies's colonists are get damage bonus 1/4 of orignal bonus.

Same bonus is applied. 7b9c9309c0ea6b62733e000514b073b8b90c7f00

xianyullm commented 2 months ago

MineColonies's colonists are get damage bonus 1/4 of orignal bonus.MineColonies 的殖民者获得原始加成 1/4 的伤害加成。

Same bonus is applied. 7b9c930适用相同的奖金。 7b9c930

The damage caused by Gunner's agility99 and adaptivity 99 is exactly the same as agility1 and adaptivity 1