Address csslint warnings - Githubissues

gisforgabriel / CV-olio

A Jekyll template for a simple CV & portfolio website

https://cv-olio.netlify.com/cv

MIT License

3 stars 1 forks source link

Address csslint warnings #28

Open gisforgabriel opened 7 years ago

gisforgabriel commented 7 years ago

For example blockquote and also look at other csslint warnings e.g. bulletproof font loading

gisforgabriel commented 7 years ago

removed unused blockquote - https://github.com/gisforgabriel/CV-olio/commit/a833e15d8336c8179058ef563ac11f846e674709

gisforgabriel commented 7 years ago

Addressed alphabetising css rules in https://github.com/gisforgabriel/CV-olio/commit/c4fe4ef16bcc6c14a64913504c01f96d03f7fd9a https://github.com/gisforgabriel/CV-olio/commit/12017b393192efb965119fc80a4f7e90e358a9f9 & https://github.com/gisforgabriel/CV-olio/commit/483e046e76578629b050057b06e5a5892c86297a. Need to fork patternbolt to reorder html css rules, to be fully compliant.

[x] remove unused CSS rules (blockquote) - https://github.com/gisforgabriel/CV-olio/commit/a833e15d8336c8179058ef563ac11f846e674709
[ ] put css rules in alphabetical order* - https://github.com/gisforgabriel/CV-olio/commit/c4fe4ef16bcc6c14a64913504c01f96d03f7fd9a https://github.com/gisforgabriel/CV-olio/commit/12017b393192efb965119fc80a4f7e90e358a9f9 https://github.com/gisforgabriel/CV-olio/commit/483e046e76578629b050057b06e5a5892c86297a https://github.com/gisforgabriel/CV-olio/commit/dfa7d750c15fea3ea482b50f087179fb3a185431 https://github.com/gisforgabriel/CV-olio/commit/42fa99987966618ac680aa1eb3d18dd036a67c5c https://github.com/gisforgabriel/CV-olio/commit/aee83af36c7928f6d85edabf2d3a3baa617808c2
[ ] address defining headings multiple times https://github.com/gisforgabriel/CV-olio/commit/e517680b0909cfa6a3398ed72ade200608a3998e
[ ] implement Fontspring @Font-Face Syntax

*Remaining issue is due to the adding an additional background-position property to the mixin constructed by patternbolt. Could omit this property if required - https://github.com/gisforgabriel/CV-olio/blob/dfa7d750c15fea3ea482b50f087179fb3a185431/_sass/_pattern.scss#L3