gisikw / foundryvtt-hotspots

FoundryVTT module for attaching macros to drawings
0 stars 0 forks source link

FoundryVTT Integration Workflow #3

Open gisikw opened 3 years ago

gisikw commented 3 years ago

Set up FoundryVTT integration workflow

Create a Github action that can:

gisikw commented 3 years ago

Dealing with multiple secrets here:

Need to ensure that PRs from malicious accounts can't simply update the workflow and output secrets - particularly given that Download URL at least must be a derived secret, and thus won't have protections Github might afford to first-class secrets. Further reading to be done: https://securitylab.github.com/research/github-actions-preventing-pwn-requests/

gisikw commented 3 years ago

Work continues - thus far, have been leveraging local Foundry install, and got install working via Github workflow. That said, feels like perhaps the downloading and spinning up of this env ought to be be managed inside package.json, hitting a different port, to bring local and CI development into parity.