search

gisikw / wemote

Wemote is a Ruby-agnostic gem for Wemo light switches
MIT License
8 stars 6 forks source link

Search devices through SSDP, add basic support to Wemo Insight #3

Closed luca776 closed 6 years ago

luca776 commented 6 years ago

Instead of maintaining the list of MAC addresses, the search is performed through the SSDP protocol. Insight class add support to "standby?" state and can determine the power consumption of the device.

gisikw commented 6 years ago

Thanks for the PR! I unfortunately don't have devices to quickly test with, and it's been a while since I've used this. I have a vague recollection of running into problems with SSDP when running on JRuby. If it's not too much trouble, mind verifying that this works in that environment?

luca776 commented 6 years ago

Ok, you were right, there was an issue with JRuby, I fixed it on SSDP and the author was very fast to merge my Pull Request. Now I added the dependency to the new gem version (>=1.1.6) and I removed some duplicate code in the Insight sublclass.

luca776 commented 6 years ago

@gisikw do you think it's okay?

gisikw commented 6 years ago

So sorry for the delay on this. Thanks for getting it working with JRuby - excited not to be shelling out :)