gismofx / toast_ui.blazor_calendar

Toast UI Calendar Wrapper For Blazor
MIT License
54 stars 8 forks source link

Upgrade to @toast-ui/calendar v.2.1.3 #48

Open KevinKrueger opened 8 months ago

gismofx commented 8 months ago

Thanks! Should be simple to do :).. unless...Are there any new features or API changes on the toast calendar side?

KevinKrueger commented 8 months ago

Not that is would know.

It would be important to me that this also works well for WASM without server-side.

KevinKrueger commented 8 months ago

Of course a 1.0.0 version would also be cool :)

KevinKrueger commented 8 months ago

I use MudBlazor and I noticed that when I press Edit in the popup for an appointment, it reloads the page.

KevinKrueger commented 8 months ago

It would be great if we could get Syncfusion, Devexpress and Telerik to drop their jaws. They have stupid license models.

gismofx commented 8 months ago

I use MudBlazor and I noticed that when I press Edit in the popup for an appointment, it reloads the page.

Can you upload a self-contained project that reproduces this error? I can take a look. I also use MudBlazor. Also, please open a new issue for this.

gismofx commented 8 months ago

Not that is would know.

It would be important to me that this also works well for WASM without server-side.

Should work just fine with WASM too.

KevinKrueger commented 8 months ago

Okay, i created a new Empty site and use your test code and it works now XD

KevinKrueger commented 8 months ago

I have already gone through it with the debugger. Nothing conspicuous.

gismofx commented 8 months ago

Ref V2 Migration guide: https://github.com/nhn/tui.calendar/blob/main/docs/en/guide/migration-guide-v2.md

I'll make branch for V2. Looks like there are some nice changes/improvements, but will take a little work to update everything. It should be minimal changes to the C# Side.

KevinKrueger commented 8 months ago

Thank you from the bottom of my heart <3 You're saving my ass in the world of not having a proper solution for Blazor.

I am available for extensive testing at any time.

gismofx commented 8 months ago

Thank you from the bottom of my heart <3 You're saving my ass in the world of not having a proper solution for Blazor.

Of course! It's the least I can do for the open source community.

I am available for extensive testing at any time.

This will be helpful! Thanks

gismofx commented 8 months ago

I've begun the conversion. NPM Packages are updated, updated options classes, and the project builds and the test project starts. No runtime errors, but there are display/rendering issues. Not sure where they are coming from. I'll share the branch tomorrow. Could be a CSS issue. More to come.

KevinKrueger commented 8 months ago

You are a machine!

KevinKrueger commented 8 months ago

Am I mistaken or have they now added a toolbar to the calendar or is it just something they developed themselves?

KevinKrueger commented 8 months ago

I have comitted my changes (Pull-Request "Update & Create Schedule") which somehow disturbed me in the development.

53

gismofx commented 8 months ago

@KevinKrueger I pushed up DevV2 branch. Have a look. I think a few of the changes in your commit are covered in this branch. Maybe you can re-apply your changes on this branch. Month view looks like this and I don't know why. image

KevinKrueger commented 8 months ago

@gismofx Cooooool :) . Looks like a css problem.

I think it would be easier to accept my pull request and make a merge in V2. // TODO: V2 is marked

KevinKrueger commented 8 months ago

55 You need to merge it (has 1 conflict) @gismofx

gismofx commented 8 months ago

Merged. Have a look. Maybe you can dig into the display issue?

KevinKrueger commented 8 months ago

I would like to open a better communication channel. What do you think of Slack? Or do you have another suggestion for better communication?

KevinKrueger commented 8 months ago

The first problem I had was that it was suddenly called TUIEvent instead of TUISchedule. The second problem is that pulling the length of the appointments no longer works. The third problem is then logically the wrong display of the month view

KevinKrueger commented 8 months ago

And my changes are not there.

gismofx commented 8 months ago

I sent you a discord link to your email in your profile. I believe a lot of your changes were absorbed within the changes I made. Overall, it's about the same.