search

gissf1 / zram-hibernate

Allows dynamic swap changes to activate disk-based storage as swap for hibernation support when a system typically uses only zram swap during normal operation.
Apache License 2.0
34 stars 3 forks source link

Add more dependencies in PKGBUILD #2

Closed JustSimplyKyle closed 1 year ago

JustSimplyKyle commented 1 year ago

There are no current listed dependencies. But looking at the code, at least awk bash sed and grep is in it.

JustSimplyKyle commented 1 year ago

You can also add detection when a command doesn't exist(aka not installed) in the script itself, I've seen this practice in several other scripts too!

gissf1 commented 1 year ago

At least for Arch Linux, all the packages it uses are part of the base install.

Was there something that it tried to use that wasn't installed by default on your install?

I updated the PKGBUILD with the ones I noticed when I skimmed through the file, just to be complete.

JustSimplyKyle commented 1 year ago

Yeah, it's all defaultly installed(base-devel) except bash, but it's still considered good practice to include all the dependencies.