search

gissilabs / charts

Apache License 2.0
38 stars 22 forks source link

[Bitwarden] Abstract away DB-WAL setting #10

Closed PrivatePuffin closed 4 years ago

PrivatePuffin commented 4 years ago

DB_WAL is either true for sqlite or false for actual databases. We can easily abstract this away (certainly when custom env's get supported)

sgissi commented 4 years ago

DB_WAL is automatically disabled on other DBs and defaults to true for SQLite. The user does have the option to disable it if he wants to. I don't think there is more abstraction needed, what do you suggest?

PrivatePuffin commented 4 years ago

@sgissi I understood it wrong: Enable DB Write-Ahead-Log for SQLite, disabled for other databases

maybe make it: Enable DB Write-Ahead-Log for SQLite, automatically disabled for other databases