search

gissilabs / charts

Apache License 2.0
37 stars 22 forks source link

Extra Env variables and Traefik middleware #12

Closed sgissi closed 3 years ago

sgissi commented 3 years ago

Allow option to inject environment variables manually. Add option to select middlewares for Traefik IngressRoute.

@Ornias1993 Can you test please? I have based this out of your patches but fixed the middleware. They are placed at "route" level instead of top-level like TLS or entrypoints.

Replaces #7, fixes #4 and #5.

PrivatePuffin commented 3 years ago

You couldve just commited to my branch instead >.<

sgissi commented 3 years ago

Sorry, I didn't realize that was possible, let me try that.

PrivatePuffin commented 3 years ago

No problem, i'm also fine with merging this into mine.

That being said:

I have based this out of your patches but fixed the middleware. They are placed at "route" level instead of top-level like TLS or entrypoints.

Please don't use a different structure than the CRD itself. So keep it in the same place for people that are used to working with the CRD directly.

sgissi commented 3 years ago

I have based this out of your patches but fixed the middleware. They are placed at "route" level instead of top-level like TLS or entrypoints.

Please don't use a different structure than the CRD itself. So keep it in the same place for people that are used to working with the CRD directly.

Absolutely. I misread your changes actually, I thought they were at a higher level but you did place them correctly under the routes. It was missing the same middlewares injected in the websocket part. I don't run any middleware, can you test on the new branch? I'll close this PR for now.

PrivatePuffin commented 3 years ago

Yeah I missed one route, sorry! >.<

PrivatePuffin commented 3 years ago

Fine with closing btw! :)