gissilabs / charts

Apache License 2.0
37 stars 22 forks source link

feat: add missing env configs and session storage definition #17

Closed antonanders closed 3 years ago

antonanders commented 3 years ago

This PR improves the handling of S3 configuration and adds an additional env array, which can be passed to configure custom-build images. A PVC is also added to allow sessions to service a pod restart.

This PR relates to the following 3 PRs:

A docker image we use internally in our company, which has all these PRs enabled, can be found on docker hub: https://hub.docker.com/r/droidsolutions/leantime

sgissi commented 3 years ago

Thank you for the PR! It looks really good and the first two PR's against Leantime are already merged. I'll merge this PR as soon as a new Leantime release gets published.

sgissi commented 3 years ago

Ok, Leantime 2.1.7 has your patches. Just pending on the docker-leantime PR before I can merge.

sgissi commented 3 years ago

Thanks for your contribution. I will do a few updates on the 'env' part to be consistent with the other chart in the repository, bump the version and test.