search

gissilabs / charts

Apache License 2.0
37 stars 22 forks source link

feat: support v1 Ingress #23

Closed jonkerj closed 3 years ago

jonkerj commented 3 years ago

Per Kubernetes 1.22, v1beta1 ingress is dropped. This commit autodetects ingress capabilites and templates correct ingress (legacy extensions/v1beta1, networking/v1beta1 and networking/v1), including optional ingress class name.

As I do not have a < 1.18 cluster (ie, without networking/v1) around or even < 1.16 (without v1beta1) I have not been able to test if the old templating actually works.

sgissi commented 3 years ago

Thanks!

jonkerj commented 3 years ago

No prob, thank you for looking so quick into this PR. If you have a minute, I'll port these changes to your bitwardenrs chart as well in a new PR