Chart does not template v1 Ingress

gissilabs / charts

Apache License 2.0

38 stars 22 forks source link

Chart does not template v1 Ingress #24

Closed jonkerj closed 3 years ago

jonkerj commented 3 years ago

This chart templates currently deprecated/legacy Ingress, which makes it kind of tricky to use on Kubernetes 1.22 (which has dropped v1beta1 ingress). I've written a PR (#23) to address this, this is the matching issue.

sgissi commented 3 years ago

Thanks for raising the issue and proposing the PR! I added a few comments there, please take a look and then we are ready to merge. Thanks again!

sgissi commented 3 years ago

Thank you again, the changes are merged and should be published this weekend.

jonkerj commented 3 years ago

Raised #25 as well. Should have done it at once :-)

sgissi commented 3 years ago

That was really fast! :) Thank you very much, the PR is merged.

sgissi commented 3 years ago

Hi, I just released the charts with your changes, can you give it a try please? Thanks for the contribution!

jonkerj commented 3 years ago

It works, thanks!