gissilabs / charts

Apache License 2.0
37 stars 22 forks source link

Probes not passing when domain is set to subpath/subfolder #27

Closed lord-kyron closed 2 years ago

lord-kyron commented 2 years ago

Hi @sgissi , I am trying to deploy the helm chart on a domain, that I am going to use with subpath. For example https://domain.com/vault/ The problem here seems to me to be in the current config of the probes of deployment:

          livenessProbe:
            httpGet:
              path: /
              port: http
          readinessProbe:
            httpGet:
              path: /
              port: HTTP

With this setup when enter in values.yaml https://example.com/vault as my domain, the probes are failing with:

Readiness probe failed: HTTP Probe failed with statuscode: 404
Liveness probe failed: HTTP Probe failed with statuscode: 404

However, when I change this value to my domain only, without the subpath - https://example.com - the probes are passing and the deployment is up, however because I am running behind nginx reverse proxy it seems not working well and some stuff are broken other stuff tries to redirect me to the main domain, not to the subpath that I am using. Can you fix this and make those probes config exposed in the values yaml for example to be able to configure the path and try to fix this issue this way or make it to take it dynamically from the input of the domain value?

Thanks!

sgissi commented 2 years ago

That is a good catch, thank you! There some notes at https://github.com/dani-garcia/vaultwarden/wiki/Using-an-alternate-base-dir that can help if you going down that path. I'll take a look on building the probes based on the domain setting.

lord-kyron commented 2 years ago

@sgissi sorry for asking, but can you estimate when you will be able to make some fix about it? I am waiting for this to deploy my new vaultwarden as am I a bit restricted in terms of domain usage. Thanks!

sgissi commented 2 years ago

Hi, I'm aiming to get it done by this weekend if nothing urgent comes up :)

sgissi commented 2 years ago

Hi, I just made the changes to pass the sub-path to the probes (5a028c050fb0a08e5bec3e385fc4dc58537f69fa). Can you test the latest chart release (0.4.1)?

sgissi commented 2 years ago

@lord-kyron Did you have the chance to test the new probes?

sgissi commented 2 years ago

I'll consider this closed, please reopen or create a new issue if not fixed by the commit.