search

gissilabs / charts

Apache License 2.0
37 stars 22 forks source link

Update vaultwarden to 1.25.0 and implement/fix the new SMTP configs #35

Closed lord-kyron closed 1 year ago

lord-kyron commented 2 years ago

Hi @sgissi , I noticed that vaultwarden have a new version 1.25.0 in dockerhub images, but that is not the most important part of this request. After upgrading to it I noticed this message in the container logs: [DEPRECATED]:SMTP_SSLorSMTP_EXPLICIT_TLSis set. Please useSMTP_SECURITYinstead.

After digging a little bit, I found the info for this change: NOTE: Vaultwarden version before v1.24.0 had a bug/mislabelled configuration setting regarding SSL and TLS. This has been fixed in testing and newer released versions. The old settings were SMTP_SSL and SMTP_EXPLICIT_TLS. The new setting is SMTP_SECURITY which has the following options: starttls, force_tls and off. SMTP_SSL=true equals starttls SMTP_EXPLICIT_TLS=true equals force_tls The examples below still represent v1.24.0 for now.

Here is the link to the documentation, referring to that: https://github.com/dani-garcia/vaultwarden/wiki/SMTP-Configuration

So my request is to release a new version of the helm chart with those changes to SMTP implemented and best will be if the image version is also updated. Thanks!

lord-kyron commented 2 years ago

Actually @sgissi I've created a pull request for those fixes, to ease your work :) Here it is: Pull request #36