gissilabs / charts

Apache License 2.0
38 stars 22 forks source link

The helm chart on artifacthub contain old api #51

Closed yodatak closed 5 months ago

yodatak commented 7 months ago

The helm chart present on artifact hub is old and contain deprecated ingress api but the git is good but not the helm chart published in artifacthub

{{- if semverCompare">=1.14-0" .Capabilities.KubeVersion.GitVersion -}}
apiVersion: networking.k8s.io/v1beta1

https://artifacthub.io/packages/helm/gissilabs/leantime?modal=template&template=ingress.yaml

The chart is not realy updated in version leantime-1.1.0.tgz https://github.com/gissilabs/charts/actions/runs/8193895940/artifacts/1307134620

sgissi commented 6 months ago

@yodatak Can you check if it is better now? I released a new chart today.

yodatak commented 5 months ago

Its now fixed but it don't work because pathType is mandatory see my pR ( untested for now) #54

sgissi commented 5 months ago

Hi, I merged the PR. Also, beyond pathType, the backend service changed from serviceName/servicePort to service.name and service.port.number/service.port.name. I created a new version of the chart (1.2.0), can you test please?

sgissi commented 5 months ago

Closing the issue for now as the latest charts should work as intended. Please re-open if not the case.