gissilabs / charts

Apache License 2.0
37 stars 22 forks source link

Update template to make it stable ingress api pathType is mandatory #54

Closed yodatak closed 4 months ago

yodatak commented 4 months ago

Now in stable ingress api pathType is mandatory

since Kubernetes v1.19 [stable]

I think we must delete the old API capacibility

i cannot install in k3s because of this error when i enable ingress spec.rules[0].http.paths[0].pathType: Required value: pathType must be specified

we must maybe add some test and propose to leantime to help to maintain the helm chart ?

Thanks again im searking for tdah task tools because you know how life is hard ^

yodatak commented 4 months ago

Here my ingress i had manual in rancher

apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: leantime
  namespace: leantime
spec:
  ingressClassName: traefik
  rules:
    - host: leantime.XXXXX
      http:
        paths:
          - backend:
              service:
                name: leantime
                port:
                  number: 80
            path: /
            pathType: Prefix
  tls:
    - hosts:
        - leantime.yodatak.fr

i got wildcard tsl altready

sgissi commented 4 months ago

Thanks for that. Ingress at networking.k8s.io/v1beta1 was removed on 1.22, almost 2 years ago. It is safe to remove support for it now. I'll update that and Vaultwarden in the coming days. For reporting the issue and the proposed patch.

sgissi commented 4 months ago

Thanks for the PR, there are some additional changes required, I'll push them soon.