Closed PrivatePuffin closed 3 years ago
@sgissi It passed my CI now and it's cleaned up a little :)
@Ornias1993 Can you check the patches I have sent? I reverted the space change and updated the rest. I understand they came from YAML lint but suggestions need to take context into consideration. Explanation comments must adhere to the spacing so they are readable. Configuration options is a different thing, likely I will make them explicit instead of a comment section in the future but for now, I will keep the current format without the leading space and with a trailing space.
Trailing spaces are "how not to code or comment 101"
Not using spaces in front of commenting is very non-standard and not something i'm even open to discussing. It's freaking confusing because no-one does.
Sorry you're not going to change my mind on that.
About the code:
No problem, I was just explaining my rationale, not trying to change your mind. For regular comments we are in agreement (leading space, no trailing). For configuration options, I rather have the way I did. We can agree to disagree on that :)
I'll finish my testing and merge. Thank you very much for the help and effort getting these features in.
We can agree to disagree on that :)
Precisely! 👍
I'll finish my testing and merge. Thank you very much for the help and effort getting these features in.
No problem, thanks for the quick work on this :)
This PR adds:
Please do confirm this is working with additional testing
Fixes #4 Fixes #5