search

git-afsantos / haros

H(igh) A(ssurance) ROS - Static analysis of ROS application code.
MIT License
190 stars 37 forks source link

Find workspace built with catkin_make_isolated #35

Closed nlimpert closed 5 years ago

nlimpert commented 5 years ago

As part of our work proposed in https://github.com/ros-infrastructure/ros_buildfarm/issues/596 we would like to make use of haros for packages defined as a catkin test. Please see https://github.com/ipa-jfh/haros_catkin as an example.

The scripts running the devel jobs on the buildfarm make use of catkin_make_isolated and as such I would prefer to extend haros to run in a workspace built with catkin_make_isolated.

nlimpert commented 5 years ago

@gavanderhoorn @itualami @droter @ipa-jfh fyi

git-afsantos commented 5 years ago

Looks good to me. Is this already tested?

nlimpert commented 5 years ago

Looks good to me. Is this already tested?

Thanks for the quick response. Yes I just tested it and it works with ROS Workspaces built with either catkin_make, catkin_make_isolated or catkin build. In particular I tested it with the kobuki_auto_docking package from https://github.com/yujinrobot/kobuki.

git-afsantos commented 5 years ago

Great! I will prepare a new release including this feature, then. :+1: :ship:

git-afsantos commented 5 years ago

FYI, your feature has just been released in HAROS v3.1.0 (PyPi).