git-afsantos / haros

H(igh) A(ssurance) ROS - Static analysis of ROS application code.
MIT License
191 stars 37 forks source link

Plugin handling might be done via pip instead of git #62

Closed nlimpert closed 5 years ago

nlimpert commented 5 years ago

During the initial setup operations haros executes git to either clone or update the plugins repository found at https://github.com/git-afsantos/haros_plugins:

https://github.com/git-afsantos/haros/blob/45b4bbd0644e4b1edbf4177531ba2b863a3db211/haros/haros.py#L406-L419

As this obviously requires git to be installed this causes an issue when using haros from within haros_catkin inside a buildfarm docker container. The docker container of interest is the docker_build_and_test which won't include git by default (cf. https://github.com/rosin-project/haros_catkin/issues/10).

Would it be better to release the plugins in a separate package via pip instead of manually invoking git?

git-afsantos commented 5 years ago

I am working on this, as per the discussion on rosin-project/haros_catkin#10.

Releasing haros_plugins as a pip package has some implications, such as:

Since I am short on time, I will be adopting plugins based on naming conventions (first option on this page). In a future version, I might change it, e.g., to option 3 using entry points.

nlimpert commented 5 years ago

Thanks again! Much appreciated!

I was hesitating to extend https://github.com/git-afsantos/haros/issues/14 with this but I think it is still related.

git-afsantos commented 5 years ago

I just released 3.3.0 with #63, which should solve this issue.