Closed nlimpert closed 5 years ago
I am working on this, as per the discussion on rosin-project/haros_catkin#10.
Releasing haros_plugins
as a pip
package has some implications, such as:
~/.haros/plugins
anymore;Since I am short on time, I will be adopting plugins based on naming conventions (first option on this page). In a future version, I might change it, e.g., to option 3 using entry points.
Thanks again! Much appreciated!
I was hesitating to extend https://github.com/git-afsantos/haros/issues/14 with this but I think it is still related.
I just released 3.3.0
with #63, which should solve this issue.
During the initial setup operations
haros
executesgit
to either clone or update the plugins repository found at https://github.com/git-afsantos/haros_plugins:https://github.com/git-afsantos/haros/blob/45b4bbd0644e4b1edbf4177531ba2b863a3db211/haros/haros.py#L406-L419
As this obviously requires
git
to be installed this causes an issue when usingharos
from withinharos_catkin
inside a buildfarm docker container. The docker container of interest is thedocker_build_and_test
which won't include git by default (cf. https://github.com/rosin-project/haros_catkin/issues/10).Would it be better to release the plugins in a separate package via
pip
instead of manually invokinggit
?