git-ced / solid-plyr

A simple HTML5, YouTube, and Vimeo player (Plyr) for SolidJS
https://solid-plyr.netlify.app/
MIT License
26 stars 4 forks source link

Issue with exports from dashjs? #5

Open senkwe opened 2 years ago

senkwe commented 2 years ago

Playing around with this lib and encountered the following error for what looks like a simple setup.

_The requested module '/nodemodules/dashjs/dist/dash.all.debug.js?v=f211ddad' does not provide an export named 'default'

My imports

import { SolidPlyr } from 'solid-plyr';
import { SourceInfo } from 'plyr';

JSX <SolidPlyr source={currentSolidPlyrObjectURL()!} />

And finally currentSolidPlyrObjectURL is set to

let si: SourceInfo = {
            type: 'video',
            sources: [{
                src: videoObjectURL,
                type: 'video/mp4',
                size: 720,
            }
            ]
        };

setCurrentSolidPlyrObjectURL(si);
vadimegorov13 commented 2 years ago

I have the same problem, did you manage to figure out the workaround?

HendrikWDev commented 2 years ago

I got the same exact issue. Looks like the problematic import is in the index.ts file of the createDashPlyr folder.

Is there any update or workaround for this problem?

gokel166 commented 2 years ago

I am also getting a similar issue as well.

DashJSSolidPlyrIssue

Omar0Gamal commented 2 years ago

did any one find a fix for this issue

HendrikWDev commented 2 years ago

@Omar0Gamal I just went back to using the Plyr library according to the Youtube embed documentation: https://github.com/sampotts/plyr#youtube.

type PlayerProps = {
    videoId: Accessor<string>
}

export const PlayerComponent: Component<PlayerProps> = (props: PlayerProps) => {
    return (
        <div class="player-container">
            <div class="plyr__video-embed" id="player" data-plyr-provider="youtube" data-plyr-embed-id={props.videoId()} />
        </div>
    );
};
Vertixx01 commented 1 year ago

someone actually help please!

TheElegantCoding commented 8 months ago

seme here seems that this package is obsolete