Closed emmakat closed 4 years ago
Multiple drives are currently not supported because the drive to use (e.g. /dev/sr0
or /dev/sg1
) is not specified explicitely at the moment.
It should be possible to implement that feature. Things to consider:
udev
rule has to be extended to give the device name as argument to bin/rip-disc
.main()
function in services/rip-disc
has to be extended to read the first argument and give it to the ripper applications.rip-disc
uses a timestamp in the container name, it should be safe to run multiple containers concurrently, as long as discs differ and at least 1 second lies between starts.Please don't expect an implementation in the near future. I'm currently quite busy, and testing would be a challenge because I own just a single drive. I'd like to encourage you to implement the feature and create a pull request against branch develop
.
wow! that's amazing - thank you! I will try it today.
So far so good. First, a compliment: The instructions work out of the box with no modifications! I'm currently ripping a bluray and it's proceeding nicely. I will try multiple drive configuration next (it gave me errors initially, will try again shortly).
@emmakat Could you give a short status report?
Yes, so sorry for the delay. I will re-run with multiple drives later today and give you an update.
and thank you again for working on this! I know you're busy, but it's just awesome that you took the time to add this feature.
SUCCESS! I'm happily ripping 3 disks at the moment. The order in which they are listed in rip-disk.yml is important. The /dev/sg1 has to be listed first, then the /dev/sr1, if you put it the other way around, it fails. Thank you!!
Thanks for your feedback!
I don't understand why the order of devices should make any difference... is an error message returned?
If you think that the issue is solved, please close it.
Thank you again for responding to my inquiry, I appreciate it! I seem to have worked out many of the getting started hiccups.
One big question I have is whether this project can support multiple drives, and rip from each of them. I have a blu ray drive, a regular dvd drive, and 5 optical drives. When I add all of the drives, or even 1 additional drive, it causes my working rip (the blu ray) to fail. Based on https://askubuntu.com/questions/921235/udev-rules-for-launching-scripts-when-dvd-loaded-multiple-drives and what I see in udev disc detection rules, it appears as though it does support multiple drives.
I have a makemkv container which if I run it without loading any drives, it will tell me what I have available but didn't expose to the container. (I used this to inform what I put in rip-disc.yml)
Based on this, I loaded this into the rip-disc.yml. I have commented out everything except the blu ray device though, because when I try to include even 1 additional drive, nothing works.
2020-05-21T03:22:33.614239038Z Error 'Scsi error - NOT READY:MEDIUM NOT PRESENT - TRAY OPEN' occurred while reading '/BDMV/STREAM/00800.m2ts' at offset '2626289664' 2020-05-21T03:22:34.014817843Z Backup failed 2020-05-21T03:22:34.014833119Z Backup failed. 2020-05-21T03:22:34.149328316Z Kopie von 'ATTACK_OF_THE_CLONES' mit Erfolg beendet.
It was happily ripping Attack of the clones, then I opened one of the cdrom drives, and put music disc in there. It immediately crashed the bluray rip and gave me the above error.