git-ecosystem / git-bundle-server

A web server & management CLI to host Git bundles for use with Git's "bundle URIs" feature
Other
43 stars 20 forks source link

Bundle list routing + other bugfixes #34

Closed vdye closed 1 year ago

vdye commented 1 year ago

Fixes #32

While end-to-end testing, I ran into #32; while investigating that bug, I found a couple others. This PR fixes all of the ones I've found, and adds some unit test coverage for good measure.

Other approaches to #32

I also considered generating the bundle list config contents on the fly (by reading the bundle-list.json and formatting the output), but the cost tradeoff of computation for every request vs. a bit of extra disk space seemed to favor the latter.

vdye commented 1 year ago

Upon doing more testing, I've found more bugs (e.g., git-bundle-server update never calls git fetch, so no new bundles will ever be created). I don't think that affects the other bugfixes (those can be reviewed as-is), but I will be pushing more things to this branch in the near future.