search

git-ecosystem / git-bundle-server

A web server & management CLI to host Git bundles for use with Git's "bundle URIs" feature
Other
43 stars 20 forks source link

Add integration tests #39

Closed ldennington closed 1 year ago

ldennington commented 1 year ago

This series adds integration tests, using the example set with the end-to-end tests in #33.

The first commit refactors certain components of the end-to-end tests to prepare for the new integration suite. The second commit adds the basic infrastructure and tests for the core bundle server commands. The third adds tests for basic daemon functionality. The fourth updates the Makefile to add targets to run unit tests, integration tests, and all tests. The fifth adds applicable tests from the integration suite to CI.

ldennington commented 1 year ago

@vdye @derrickstolee - Opening this as a draft PR, as I'd like to add some more commands and an actions workflow before merging. However, I'm sure there are lots of areas for improvement, so wanted to open up the floor for feedback as soon as possible.

ldennington commented 1 year ago

I believe all the previous feedback has been addressed, either directly or via another suggested refactor. Please share any additional suggestions you have for improvement on the new changes (command tests, the refactors for sharing code, CI, etc.)

vdye commented 1 year ago

@ldennington I've also unmarked e2e-test as required for merging, and will make Integration and end-to-end tests (or whichever name it ends up with) required after merging this.

vdye commented 1 year ago

Branch protection rules have been updated!