git-ecosystem / git-bundle-server

A web server & management CLI to host Git bundles for use with Git's "bundle URIs" feature
Other
43 stars 20 forks source link

Add basic support & documentation for built-in and plugin-based auth #51

Closed vdye closed 1 year ago

vdye commented 1 year ago

Closes #41

This pull request lays the foundation for specialized auth configuration in the bundle server:

This is a pretty major feature (or the start of one, at least), so I'd really appreciate an extra reviewer focus on making sure the architecture is sound and there aren't any glaring security issues (other than what's already mentioned in the docs, i.e. "don't run untrusted plugins").

vdye commented 1 year ago

@derrickstolee @mjcheetham I think I've addressed all of the feedback so far. The PR has changed a fair amount since the first round of reviews (added integration tests, manpage docs, and better in-code documentation for pkg/auth; also, changed AuthResult pretty substantially), so please let me know if you have any questions or otherwise think something should be changed! šŸ™‡ā€ā™€ļø