Closed bilbothebaggins closed 1 year ago
Thank you for pointing this out - the maintainers will investigate.
We identified an issue with our legacy WPF-based UI on Windows that was not using the correct encoding. This has been fixed in the latest release.
Version
2.0.886+ea93cb5158
Operating system
Windows
OS version or distribution
Windows 10 Enterprise LTSC 1809 17763.4377, German CP Win-1252
Git hosting provider(s)
Bitbucket Server/DC, Other - please describe below
Other hosting provider
generic git-credential-manager-ui.exe
(Azure DevOps only) What format is your remote URL?
None
Can you access the remote repository directly in the browser?
Yes, I can access the repository
Expected behavior
I should be able to enter any password in the git-credential-manager-ui.exe Popup or the Atlassian.Bitbucket.UI.exe Popup and have git-credential-manager correctly use that.
Actual behavior
If, and only if, the password of the user contains a non-ascii character (German Umlaut), the result will be:
fatal: Authentication failed for 'https://...'
From the logs below, it appears that with the password entry via the GUI, the password is double UTF-8 Encoded.
password=Atlassian_bl├Â_123
- allowing for the cmd.exe code page, this is the display of the UTF-8 bytes of the real passwordpassword=Atlassian_blÔö£├é_123
- the 5 bytesÔö£├é
is what happens when you take the UTF-8 bytes as Iso-8859-1 (or Win-1252) and re-encode these as UTF-8!Logs
When it works:
When it does not work: