search

git-ecosystem / git-credential-manager

Secure, cross-platform Git credential storage with authentication to GitHub, Azure Repos, and other popular Git hosting services.
Other
6.91k stars 1.82k forks source link

Remove misleading error message #1694

Closed Regenhardt closed 1 month ago

Regenhardt commented 2 months ago

GitLab is used for internal hosting, which may often use unencrpted http. This error message is misleading, as the process continues and works regardless, and also falsely mentions Github instead of GitLab.

Got a new PC at work. First clone of the GitLab repo I'm working on went like this:

goxijana3 commented 2 months ago

GitLab is used for internal hosting, which may often use unencrpted http. This error message is misleading, as the process continues and works regardless, and also falsely mentions Github instead of GitLab.

Got a new PC at work. First clone of the GitLab repo I'm working on went like this:

* run git clone on an http GitLab instance, in my case I ran `git clone http://gitlab.company-local-domain.de/group/project LocalRepo-Name`
  Note:

  * http, not https
  * GitLab

* Get the following error message:
  fatal: Unencrypted HTTP is not supported for GitHub. Ensure the repository remote URL is using HTTPS.

* Get prompted for and enter credentials

* Get warning about redirecting to .git URL

* Cloning commences and finishes successfully

Regenhardt:feature/gitlab-gets-github-error

mjcheetham commented 1 month ago

Thank you for your PR! We have addressed this issue of not being able to use http:// remotes with GitLab with this other PR https://github.com/git-ecosystem/git-credential-manager/pull/1721

Regenhardt commented 1 month ago

That just changes the error message at default settings, but doesn't change the behaviour, does it? The message is then still misleading, as it implies that you have to change a setting and try again, but then still proceeds with the authentication?