search

git-ecosystem / git-credential-manager

Secure, cross-platform Git credential storage with authentication to GitHub, Azure Repos, and other popular Git hosting services.
Other
6.72k stars 1.75k forks source link

Review/Rationalise the environment and configuration options used by Bitbucket Cloud and DC #769

Open mminns opened 2 years ago

mminns commented 2 years ago

Description

Currently the implemented support for Bitbucket Cloud and DC includes a duplicated set of configuration or environment options e.g.

credential.bitbucketDataCenterOAuthClientSecret vs credential.cloudOAuthClientSecret

GCM_BITBUCKET_DATACENTER_CLIENTID vs GCM_BITBUCKET_CLOUD_CLIENTID

Conceptually there should be no reason for duplicating the configuration options because the use of the target url in the configuration should be sufficient to differentiate between cloud vs DC.

e.g.

credential.http://bitbucket.org.oauthClientSecret vs credential.http://example.com/bitbucket.oauthClientSecret

However it is not as clear cut with the Environment variables, since they do not have the flexibility to target explicit urls, so they should probably stay distinct cloud vs DC.

IjobaFifti commented 2 years ago

Love

ldennington commented 2 years ago

Sounds like a good idea!