search

git-ecosystem / trace2receiver

GOLANG based OTEL custom collector receiver component for Trace2 data
MIT License
44 stars 7 forks source link

Replace host.ReportFatalError with ReportStatus in rcvr_unixsocket #21

Closed maxious closed 8 months ago

maxious commented 8 months ago

https://github.com/open-telemetry/opentelemetry-collector/pull/9506 removed deprecated codepath for fatal errors in reciever setup so need to replace to have compatibility with newer otel

I've tested this with an invalid socket path and bumped the dependencies too in a seperate commit https://github.com/open-telemetry/opentelemetry-collector-releases/releases 

error   trace2receiver@v0.5.1/rcvr_unixsocket.go:173    could not create socket: listen unix /usr/trace2.socket: bind: operation not permitted  {"kind": "receiver", "name": "trace2receiver", "data_type": "traces"}
github.com/git-ecosystem/trace2receiver.(*Rcvr_UnixSocket).openSocketForListening
        github.com/git-ecosystem/trace2receiver@v0.5.1/rcvr_unixsocket.go:173
github.com/git-ecosystem/trace2receiver.(*Rcvr_UnixSocket).Start
        github.com/git-ecosystem/trace2receiver@v0.5.1/rcvr_unixsocket.go:46
jeffhostetler commented 8 months ago

Hey Alex, thanks for the PR. Let me take a look and get back to you.