search

git-for-windows / git-for-windows-automation

A few GitHub workflows and support code to help with Git for Windows' day-to-day tasks
10 stars 9 forks source link

build-and-deploy: do not skip the `refresh` step #36

Closed dscho closed 1 year ago

dscho commented 1 year ago

In https://github.com/git-for-windows/git-for-windows-automation/actions/runs/4231051093/jobs/7349093571#step:22:49, we see what happens if, say, the pacman step fails and the refresh step is skipped: we try to update the check run but fail to refresh the token that is necessary to do that.

In another run the symptom looks different: it is indicated that we run into API rate limiting. That's because the used token is empty and therefore we run unauthenticated.

Fix that by forcing the refresh step just like the update check-run step.

dscho commented 1 year ago

https://github.com/git-for-windows/git-for-windows-automation/pull/38 made this obsolete, as it removed the refresh step.