Adjust the `tag-git` workflow and create a `release-git` workflow to build Git for Windows fully using GitHub Actions

git-for-windows / git-for-windows-automation

A few GitHub workflows and support code to help with Git for Windows' day-to-day tasks

10 stars 9 forks source link

Adjust the `tag-git` workflow and create a `release-git` workflow to build Git for Windows fully using GitHub Actions #38

Closed dscho closed 1 year ago

dscho commented 1 year ago

[x] adjust the tag-git workflow so that it can tag full Git for Windows versions, not just snapshots
[x] adjust the git-artifacts workflow to mirror Check Runs to git-for-windows/git (needs to encode the architecture as part of the Check Run name to avoid them overwriting each other)
[x] reimplement the Azure Release Pipeline as new GitHub workflow, called release-git

This addresses https://github.com/git-for-windows/git-for-windows-automation/issues/37

dscho commented 1 year ago

Finally!!!

For comparison, this is is what the Azure Release Pipeline looked like:

dscho commented 1 year ago

The next steps will be to merge this (after dropping the TO-DROP and Revert commits that are at the top of the branch, to ease development by allowing to trigger the workflows even if they are in a non-default branch, for which you can trigger workflow_dispatch only if the default branch has a workflow of the same name), and then to adjust https://github.com/git-for-windows/gfw-helper-github-app/'s /git-artifacts and /release commands to use the new workflows.

dscho commented 1 year ago

@rimrul FWIW my plan is to merge this PR today (after squashing the fixups/amends), and probably also https://github.com/git-for-windows/gfw-helper-github-app/pull/29.

This has been a huge lift for me, therefore I might not actually be up to going through with the /git-artifacts//release invocations today, in particular given that the Git maintainer is in a timezone that's 9h behind mine.

rimrul commented 1 year ago

I'll try to get a review for https://github.com/git-for-windows/gfw-helper-github-app/pull/29. and a final review for this PR in. But the latter will likely be close to the scheduled release time for 2.40.0-rc2.

dscho commented 1 year ago

I'll try to get a review for git-for-windows/gfw-helper-github-app#29. and a final review for this PR in. But the latter will likely be close to the scheduled release time for 2.40.0-rc2.

@rimrul thank you so much!

Would you be okay with me merging the PRs when I need them, and implementing any changes in response to your review in follow-up PRs?

rimrul commented 1 year ago

Yes.

dscho commented 1 year ago

Okay, let's go.

dscho commented 1 year ago

Full disclosure: these are the fixes that were needed after merging this PR: https://github.com/git-for-windows/git-for-windows-automation/compare/69b0b5f47de9ba1b9bfbabf3df496487c22be181...f2ef37027006581c06999eeed3c7fad9120f66cd