search

git-for-windows / git-for-windows-automation

A few GitHub workflows and support code to help with Git for Windows' day-to-day tasks
10 stars 9 forks source link

Fix pushing `MINGW-packages` updates in the `release-git` workflow #42

Closed dscho closed 1 year ago

dscho commented 1 year ago

While the release-git workflow run looked as if it performed all the repository updates as expected, it actually only fetched from the MINGW-packages.bundle but did not merge the change. As a consequence, the git push had no updates to offer.

I fixed that by manually downloading the bundle in the git-artifacts (x86_64) run's pkg-x86_64 artifact and pushing https://github.com/git-for-windows/MINGW-packages/commit/13a189253e9fef04e18fdbd51254930905c3b9b1.

However, it is a better idea to fix this in the release-git workflow than to do that manual fix-up for every release.

dscho commented 1 year ago

@rimrul could I solicit your review? My plan is to exercise this code in the next -rc0 already (scheduled for May 12th) and I would therefore like to merge this PR before then.