search

git-for-windows / git-for-windows-automation

A few GitHub workflows and support code to help with Git for Windows' day-to-day tasks
10 stars 9 forks source link

Fixes for check run updates #47

Closed dscho closed 1 year ago

dscho commented 1 year ago

The latest git-artifacts run failed because the installation token was created more than 10 minutes before the portable and the nuget jobs were actually started (they were queued for a long time because of some concurrent workflow runs using up the contingent of hosted runners available to the Git for Windows project).

This uncovered the fact that we fail to re-generate new installation tokens because the Action lacks the proper information: it needs a repository to work with, but that information was not passed as parameter.

This is a wide-spread issue: the check-run-action actually requires the owner/repo information in case a new installation token needs to be generated.

This PR fixes all of those instances, and while in the space also ties up a few other loose ends.

dscho commented 1 year ago

Hmm. After having another look, I think my fix is wrong. The idea was, after all, to store the relevant information in the state file, including the owner and the repository.

dscho commented 1 year ago

There you go. That's the ticket. The owner/repo information was stored in the state file, but I simply forgot to use it 😄. Now this PR is ready to be merged.

dscho commented 1 year ago

I'll just merge this before building another set of Git artifacts over in https://github.com/git-for-windows/git/pull/4426.