git-for-windows / git-for-windows-automation

A few GitHub workflows and support code to help with Git for Windows' day-to-day tasks
10 stars 9 forks source link

git-artifacts: be more patient while waiting for `tag-git` to finish #57

Closed dscho closed 7 months ago

dscho commented 7 months ago

It is important for the git-artifacts job to wait for the tag-git job to finish because it requires the latter's build artifacts, yet it is started before the latter actually finishes.

However, polling every second, up to 30 times, is way too impatient. There are sometimes glitches that make tag-git take longer to spin down, and we don't want the git-artifacts job to fail because of that. Yet this is what actually happened today, when I tried to take care of Git for Windows v2.43.0-rc1: x86_64 run and i686 run.

Let's just look only every 10 seconds, it does not make much difference to the overall run time, and for good measure let's wait up to ~10 minutes.