search

git-for-windows / git-for-windows-automation

A few GitHub workflows and support code to help with Git for Windows' day-to-day tasks
10 stars 11 forks source link

`build-and-deploy`: arm64 fixes for GPG signing #8

Closed dennisameling closed 1 year ago

dennisameling commented 1 year ago

As reported here, the Get GPG key(s) step wasn't working on arm64.

gpg: key 88138B9E1A9F3986: public key "Johannes Schindelin <johannes.schindelin@gmx.de>" imported
gpg: no running gpg-agent - starting '/usr/bin/gpg-agent'
gpg: waiting for the agent to come up ... (5s)
gpg: waiting for the agent to come up ... (4s)
gpg: waiting for the agent to come up ... (3s)
gpg: waiting for the agent to come up ... (2s)
gpg: can't connect to the agent: IPC connect call failed

After way too many (failed) attempts to fix things, I debugged by trying gpg-agent --daemon directly in the pipeline and found the following:

gpg-agent[768]: directory '/d/actions-runner/_work/git-for-windows-automation/git-for-windows-automation/home/.gnupg' created
gpg-agent[768]: directory '/d/actions-runner/_work/git-for-windows-automation/git-for-windows-automation/home/.gnupg/private-keys-v1.d' created
gpg-agent[768]: socket name '/d/actions-runner/_work/git-for-windows-automation/git-for-windows-automation/home/.gnupg/S.gpg-agent.extra' is too long

Doh šŸ¤¦šŸ¼ā€ā™‚ļø I changed the path of the runner from D:\actions-runner to D:\a to get below the 100-character limit. Note that GH does this too on their hosted runners, that's why it didn't fail on the x86_64 job. See e.g. this x86_64 run.

dennisameling commented 1 year ago

Here's a successful CI run of building git-extra that has this fix applied: https://github.com/dennisameling/git-for-windows-automation/actions/runs/3771761998/jobs/6412324785

dscho commented 1 year ago

Here's a successful CI run of building git-extra that has this fix applied: https://github.com/dennisameling/git-for-windows-automation/actions/runs/3771761998/jobs/6412324785

And here is a successful run that built and deployed mingw-w64-aarch64-git-extra: https://github.com/git-for-windows/git-for-windows-automation/actions/runs/3825495631/jobs/6508527516

Now https://wingit.blob.core.windows.net/aarch64/git-for-windows.db is ready to rumble.

Thank you so much @dennisameling!

dscho commented 1 year ago

Now https://wingit.blob.core.windows.net/aarch64/git-for-windows.db is ready to rumble.

Even more importantly, https://wingit.blob.core.windows.net/aarch64/git-for-windows-aarch64.db is ready to rumble. That means that we can finally add that [git-for-windows-aarch64] section to /etc/pacman.conf.

dennisameling commented 1 year ago

Yay! That's great news! Thank you! šŸŽ‰